pin numpy to < 2.0 until tensorboard cuts a release #2641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60917879 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 492 492
Lines 47614 47645 +31
=======================================
+ Hits 45382 45413 +31
Misses 2232 2232 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60917879 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebook#2641 The latest TB version hasn't incorporated numpy2.0-compatible changes (tensorflow/tensorboard#6869 (comment)), and recently unpinned botorch (D60735276) means Ax CI is now failing. This pins numpy to < 2.0 to prevent issues in CI. Differential Revision: D60917879
bernardbeckerman
force-pushed
the
export-D60917879
branch
from
272b99d to
b12ce12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60917879 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 7, 2024
Summary: Pull Request resolved: facebook#2641 The latest TB version hasn't incorporated numpy2.0-compatible changes (tensorflow/tensorboard#6869 (comment)), and recently unpinned botorch (D60735276) means Ax CI is now failing. This pins numpy to < 2.0 to prevent issues in CI. Differential Revision: D60917879
bernardbeckerman
force-pushed
the
export-D60917879
branch
from
b12ce12 to
281a7cd
Compare
Summary: Pull Request resolved: facebook#2641 The latest TB version hasn't incorporated numpy2.0-compatible changes (tensorflow/tensorboard#6869 (comment)), and recently unpinned botorch (D60735276) means Ax CI is now failing. This pins numpy to < 2.0 to prevent issues in CI. Differential Revision: D60917879
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60917879 |
bernardbeckerman
force-pushed
the
export-D60917879
branch
from
281a7cd to
b7bddf0
Compare
Contributor
|
This pull request has been merged in 8ba04b7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The latest TB version hasn't incorporated numpy2.0-compatible changes (tensorflow/tensorboard#6869 (comment)), and recently unpinned botorch (D60735276) means Ax CI is now failing. This pins numpy to < 2.0 to prevent issues in CI.
Differential Revision: D60917879