Add STATUSES_EXPECTING_DATA to trials consts #2621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: During development, it became clear that I never added AutoTransitionAfterGenCriterion to the encoder/decoder registry. This is a simple diff to add that Differential Revision: D60419201
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60485193 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 492 492
Lines 47697 47701 +4
=======================================
+ Hits 45424 45428 +4
Misses 2273 2273 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: facebook#2621 We'll want to leverage this in a few places in various generation strategies we are creating. This provides an easy to use constant for which trial statuses are those that we expect to receive data from. Reviewed By: saitcakmak Differential Revision: D60485193
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60485193 |
mgarrard
force-pushed
the
export-D60485193
branch
from
d37273e to
2e5e27b
Compare
Contributor
|
This pull request has been merged in 7e60844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We'll want to leverage this in a few places in various generation strategies we are creating.
This provides an easy to use constant for which trial statuses are those that we expect to receive data from.
Differential Revision: D60485193