Remove reference_point from multi-objective benchmark problems
#2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#2618 Context: some refactoring is coming to enable benchmarking a broader class of problems in which the value that captures optimization progress (such as the ground truth) doesn't match what is observed during optimization (such as noisy measurements). This PR: * Adds a property test, asserting that with a noisy problem whose ground truth is always 3, the ground-truth vaules are always 3, and the observed values are not. * Adds a characterization (golden master) test, asserting that outputs match specific values. Passing this test doesn't indicate correctness per se, but indicates that behavior has not changed since the test was added. * Fixes stub functions for surrogate problems so that their optimization configs include `BenchmarkMetric`s, which is needed for this to work. Differential Revision: D60472381
Summary: It is not used. Differential Revision: D60474602
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60474602 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
=======================================
Coverage 95.22% 95.22%
=======================================
Files 492 492
Lines 47672 47708 +36
=======================================
+ Hits 45394 45431 +37
+ Misses 2278 2277 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been merged in e459a08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: It is not used.
Differential Revision: D60474602