In MBM model tests, match search space to model #2184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53444637 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 465 465
Lines 46100 46102 +2
=======================================
+ Hits 43721 43723 +2
Misses 2379 2379 ☔ View full report in Codecov by Sentry. |
esantorella
force-pushed
the
export-D53444637
branch
from
684ad91 to
fc5334d
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Feb 9, 2024
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once meta-pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Reviewed By: SebastianAment Differential Revision: D53444637
|
This pull request was exported from Phabricator. Differential Revision: D53444637 |
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once meta-pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them. Reviewed By: SebastianAment Differential Revision: D53444637
esantorella
force-pushed
the
export-D53444637
branch
from
fc5334d to
4d22e28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53444637 |
|
This pull request has been merged in 93c85c4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We have been testing multi-fidelity search spaces with single-fidelity models. Once meta-pytorch/botorch#2186 lands, this will raise an exception because fidelity parameters will be passed to Botorch model input constructors that don't accept them.
Differential Revision: D53444637