Skip to content

Warn if inoperable keyword arguments are passed to optimizers #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Warn if inoperable keyword arguments are passed to optimizers #1421

wants to merge 1 commit into from

Conversation

esantorella
Copy link
Contributor

Summary: The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that.

Differential Revision: D43277102

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Feb 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43277102

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023 •
edited
Loading

Codecov Report

Base: 94.62% // Head: 94.62% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (cb1043c) compared to base (0b7f4fd).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head cb1043c differs from pull request most recent head 8805903. Consider uploading reports for the commit 8805903 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
- Coverage   94.62%   94.62%   -0.01%     
==========================================
  Files         419      419              
  Lines       38926    38929       +3     
==========================================
+ Hits        36834    36836       +2     
- Misses       2092     2093       +1
Impacted Files Coverage Δ
ax/models/torch/tests/test_acquisition.py 99.06% <ø> (ø)
ax/models/torch/botorch_modular/acquisition.py 96.77% <100.00%> (+0.02%) ⬆️
...models/torch/botorch_modular/optimizer_argparse.py 100.00% <100.00%> (ø)
ax/service/tests/test_scheduler.py 98.77% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

esantorella added a commit to esantorella/botorch that referenced this pull request Feb 14, 2023
@esantorella @facebook-github-bot
Warn if inoperable keyword arguments are passed to optimizers (pytorc…
c728104 
…h#1421)

Summary:
X-link: facebook/Ax#1421

Pull Request resolved: pytorch#1677

The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that.

Reviewed By: lena-kashtelyan

Differential Revision: D43277102

fbshipit-source-id: f22b4cd1c4b6227a5210f27d1501c3667209a1d7
@esantorella @facebook-github-bot
Warn if inoperable keyword arguments are passed to optimizers (facebo…
71e61cd 
…ok#1421)

Summary:
Pull Request resolved: facebook#1421

X-link: pytorch/botorch#1677

The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that.

Reviewed By: lena-kashtelyan

Differential Revision: D43277102

fbshipit-source-id: e3a473ef47018e32b8432332033110db06b006be
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43277102

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a3d7cff.

facebook-github-bot pushed a commit to pytorch/botorch that referenced this pull request Feb 16, 2023
@esantorella @facebook-github-bot
Warn if inoperable keyword arguments are passed to optimizers (#1421)
6940b53 
Summary:
X-link: facebook/Ax#1421

Pull Request resolved: #1677

The previous diff discusses issues with kwargs in BoTorch optimizers and resolves some of them. This diff warns if keyword arguments that do nothing are passed to an optimizer, and stops Ax (botorch-modular) from doing that.

Reviewed By: lena-kashtelyan

Differential Revision: D43277102

fbshipit-source-id: b31ef580223fd9d8596a9c69ac4035cbd9e8f3ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esantorella @facebook-github-bot @codecov-commenter