fit_gyptorch_model refactor (#1371)
#1134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38692173 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D38692173 |
Summary: Pull Request resolved: #1134 X-link: pytorch/botorch#1371 This commit updates `fit_gpytorch_model` and related methods, with the aim of fixing existing issues and improving extensibility. Key changes are as follow: - Replace `fit_gpytorch_model` with `fit_gpytorch_mll`, a `Dispatcher` backed reimplementation of the original model fitting pipeline. Note that `fit_gpytorch_mll` does **not** pass `kwargs` to `optimizer` and instead introduces an optional `optimizer_kwargs` argument. - Convert `fit_gpytorch_model` into a convenience method for calling `fit_gpytorch_mll` with (limited) support for legacy API. - Add validation for multioutput GP fitting routines based on decomposing a single model into a list of independent models. - Updated unit tests for relevant code paths. Differential Revision: D38692173 fbshipit-source-id: 689f14de9c11a048dca9319863bb4c2adfe93284
|
This pull request was exported from Phabricator. Differential Revision: D38692173 |
facebook-github-bot
pushed a commit
to pytorch/botorch
that referenced
this pull request
Sep 16, 2022
Summary: X-link: facebook/Ax#1134 Pull Request resolved: #1371 This commit updates `fit_gpytorch_model` and related methods, with the aim of fixing existing issues and improving extensibility. Key changes are as follow: - Replace `fit_gpytorch_model` with `fit_gpytorch_mll`, a `Dispatcher` backed reimplementation of the original model fitting pipeline. Note that `fit_gpytorch_mll` does **not** pass `kwargs` to `optimizer` and instead introduces an optional `optimizer_kwargs` argument. - Convert `fit_gpytorch_model` into a convenience method for calling `fit_gpytorch_mll` with (limited) support for legacy API. - Add validation for multioutput GP fitting routines based on decomposing a single model into a list of independent models. - Updated unit tests for relevant code paths. Reviewed By: Balandat Differential Revision: D38692173 fbshipit-source-id: 828cff264715cfa84ca4c4361db434574cf8fbf5
facebook-github-bot
pushed a commit
to facebookresearch/aepsych
that referenced
this pull request
Sep 16, 2022
Summary: X-link: facebook/Ax#1134 X-link: pytorch/botorch#1371 This commit updates `fit_gpytorch_model` and related methods, with the aim of fixing existing issues and improving extensibility. Key changes are as follow: - Replace `fit_gpytorch_model` with `fit_gpytorch_mll`, a `Dispatcher` backed reimplementation of the original model fitting pipeline. Note that `fit_gpytorch_mll` does **not** pass `kwargs` to `optimizer` and instead introduces an optional `optimizer_kwargs` argument. - Convert `fit_gpytorch_model` into a convenience method for calling `fit_gpytorch_mll` with (limited) support for legacy API. - Add validation for multioutput GP fitting routines based on decomposing a single model into a list of independent models. - Updated unit tests for relevant code paths. Reviewed By: Balandat Differential Revision: D38692173 fbshipit-source-id: 828cff264715cfa84ca4c4361db434574cf8fbf5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/botorch#1371
This commit updates
fit_gpytorch_modeland related methods, with the aim of fixing existing issues and improving extensibility. Key changes are as follow:Replace
fit_gpytorch_modelwithfit_gpytorch_mll, aDispatcherbacked reimplementation of the original model fitting pipeline. Note thatfit_gpytorch_mlldoes not passkwargstooptimizerand instead introduces an optionaloptimizer_kwargsargument.Convert
fit_gpytorch_modelinto a convenience method for callingfit_gpytorch_mllwith (limited) support for legacy API.Add validation for multioutput GP fitting routines based on decomposing a single model into a list of independent models.
Updated unit tests for relevant code paths.
Differential Revision: D38692173