Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for L5.5 & 5.6 #21

Merged
merged 1 commit into from
Aug 31, 2019
Merged

Add support for L5.5 & 5.6 #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ErrorPage/ErrorPageViewModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ public function solutions(): array

protected function shareEndpoint()
{
return action([ShareReportController::class]);
// In L5.5 and 5.6 `action` doesn't accept callable syntax, so we crash.
// Swap back to the uglier syntax until 5.5 & 5.6 support is removed.
// The same change is not needed for telescope action call above as telescope
// min version is 5.7, so it's not an issue there.
return action('\Facade\Ignition\Http\Controllers\ShareReportController');
}

public function report(): array
Expand Down