Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(TS) Object interactivity #8401

Merged
merged 14 commits into from
Oct 30, 2022
Merged

Chore(TS) Object interactivity #8401

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e0ced33
full conversion
asturur Oct 29, 2022
17aa822
progress
asturur Oct 29, 2022
3f06785
new files
asturur Oct 29, 2022
e0e0cee
ok
asturur Oct 29, 2022
1788c26
test passing
asturur Oct 29, 2022
a643732
changelog and prettier
asturur Oct 29, 2022
08a4bab
fix(): `snapAngle`, `snapThreshold` on Object
ShaMan123 Oct 29, 2022
77dccf6
Update applymixins.ts
ShaMan123 Oct 30, 2022
214bc52
optional, no default value
ShaMan123 Oct 30, 2022
2827a34
snapping JSDOC
ShaMan123 Oct 30, 2022
10e02b4
Update src/mixins/object_interactivity.mixin.ts
asturur Oct 30, 2022
3c5206d
fixed conflicts
asturur Oct 30, 2022
f78bc47
reworked merges
asturur Oct 30, 2022
53f56db
ok
asturur Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/mixins/object_interactivity.mixin.ts 
Co-authored-by: Shachar <34343793+ShaMan123@users.noreply.github.com>
  • Loading branch information
@asturur @ShaMan123
asturur and ShaMan123 authored Oct 30, 2022
commit 10e02b40f39b1ccf6aa586ba5f4b5a5b2bc8b51b
2 changes: 1 addition & 1 deletion src/mixins/object_interactivity.mixin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class InteractiveFabricObject extends FabricObject {
* @param {Function} fn function to iterate over the controls over
*/
forEachControl(
fn: (arg0: any, arg1: string, arg2: InteractiveFabricObject) => any
fn: (control: any, key: string, fabricObject: InteractiveFabricObject) => any
) {
for (const i in this.controls) {
fn(this.controls[i], i, this);
Expand Down