Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Group): 6th Patch of New Group 🛠️ layout, angle and origin ⚡ #7867

Closed

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Apr 6, 2022

Group now respects originX/Y + angle/skewing!
It is a minor fix (to the layout engine) but a significant one.
I have committed all binaries in a single commit so you can view the diff without them.
View the diff
Merge #7859, update from master and merge this one
There are some conflicts with #7860 so we better merge that first (because conflicts are resolved there) or perhaps extract group logic and merge that.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.95 |    75.67 |   85.64 |   82.68 |                                               
 fabric.js |   82.95 |    75.67 |   85.64 |   82.68 | ...,30767,30841,30852-30917,31040,31139,31375 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Apr 6, 2022
48 tasks
@ShaMan123 ShaMan123 changed the title fix(Group): 6th Patch of New Group - layout, angle and origin fix(Group): 6th Patch of New Group 🛠️ layout, angle and origin ⚡ Apr 8, 2022
@stale stale bot added the stale Issue marked as stale by the stale bot label Apr 25, 2022
@ShaMan123 ShaMan123 added group and removed stale Issue marked as stale by the stale bot labels Apr 25, 2022
@ShaMan123
Copy link
Contributor Author

updated description

@fabricjs fabricjs deleted a comment from stale bot May 1, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jun 12, 2022
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Jun 13, 2022
@ShaMan123 ShaMan123 changed the base branch from master to v6-group-patch2 June 13, 2022 05:41
@ShaMan123
Copy link
Contributor Author

Closed because history got polluted (I need to get past my git history limitations)
Rebased to show the correct commit history
Replaced by #8004

@ShaMan123 ShaMan123 closed this Jun 13, 2022
@ShaMan123 ShaMan123 deleted the v6-group-patch6-fix-origin-angle-layout branch September 11, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant