V6: Group rewrite - closed due to polluted history #7668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02f3360.
This reverts commit 196867a.
This fixes eraser being positioned against current object transform instead of initial object transform
This reverts commit 302a23b.
This reverts commit cce4ac1.
handle transform in dedicated clip path group instead of in canvas
Only erasable objects will be visibly affected by the eraser brush.
* In order to support selective erasing all non erasable objects are rendered on the main ctx
* while the entire canvas is rendered on the top ctx.
* When erasing occurs, the path clips the top ctx and reveals the main ctx.
* This achieves the desired effect of seeming to erase only erasable objects.
This reverts commit 10bbfae.
This reverts commit 96cddc2.
|
@asturur why does all these commits show here?? |
|
the commit history is trashed so I'm closing |
ShaMan123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group Rewrite
Please read this carefully!
We will update this description continuously with relevant information so you won't need to scroll and read endless comments.
Motivation
#7473 #7316 #6776 #7136 #7299 #7130 #7142 #7449
Nested selection is a MUST.
Group isn't easy to use and is very limiting (e.g. resizing logic, customize rendering) and confusing (relative coordinate system and transform).
Rewriting Group is what fabric needs.