Fix element with clipPath and shadow svg serialization #6653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i understand the issue, the shadow-filter should be applied on the clipped object an not vice versa. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
asturur
added
svg_output
and removed
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue for the example provided in #6651, but sadly it breaks other tests and I'm not sure how I should approach this.
Before:
https://codesandbox.io/s/hopeful-lake-vvm9n?file=/src/index.js
After:
https://codesandbox.io/s/pensive-visvesvaraya-bs738?file=/index.html
I would be happy if you could provide some guidance into how broken tests can be fixed, or if my approach is completely wrong, thanks.