feat(fabric.Path) Simplify S and T command in C and Q. #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzhiyuan
reviewed
Aug 9, 2020
test/visual/svg_import.js
Outdated
| @@ -38,6 +41,10 @@ | |||
|
|
|||
| QUnit.module('Simple svg import test'); | |||
|
|
|||
| function identity (a) { | |||
| return a; | |||
There was a problem hiding this comment.
Hi, what's this function's ability?
|
i use it as a quick hack to filter out tests that have no code with
array.filter
i had some problem with a test and needed a solution but is temporary i
have to solve the test before merging
…On Sun, 9 Aug 2020 at 11:09, 琚致远 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/visual/svg_import.js
<#6507 (comment)>:
> @@ -38,6 +41,10 @@
QUnit.module('Simple svg import test');
+ function identity (a) {
+ return a;
Hi, what's this function's ability?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6507 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJDQQFGUPQ67CLM4QVYMN3R7ZRTVANCNFSM4PZA5DJQ>
.
|
|
Ok this PR was a pain. Lots of hidden hard to spot small mistakes during development. |
Merged
shanicerae
pushed a commit
to shanicerae/fabric.js
that referenced
this pull request
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More path semplification code.
Add C and Q counterpart of S and T.
Removed respective bounding box and render code.