[Bug]: minWidth of Textbox is not used anywhere in code

[radykal]

CheckList

• I agree to follow this project's Code of Conduct
• I have read and followed the Contributing Guide
• I have read and followed the Issue Tracker Guide
• I have searched and referenced existing issues and discussions
• I am filing a BUG report.
• I have managed to reproduce the bug after upgrading to the latest version
• I have created an accurate and minimal reproduction

Version

5.3.0

In What environments are you experiencing the problem?

Chrome

Node Version (if applicable)

19.8.1

Link To Reproduction

http://fabricjs.com/docs/fabric.js.html#line30476

Steps To Reproduce

I was trying to use the minWidth property of Textbox, but it is not working as expected. So I studied the code and found out it's nowhere used in the code.

It is only used in this method.

getMinWidth: function() {
      return Math.max(this.minWidth, this.dynamicMinWidth);
 },

But for rendering the textbox the minWidth and the getMinWidth method is not used. So I do not see any purpose for this property.

Expected Behavior

minWidth should set the textbox minimum width.

Actual Behavior

minWidth property is not working as expected.

Error Message & Stack Trace

No response

[asturur]

oh thank you for reporting.
We need to track down how it was used before in 5.x and understand what happened

[gloriousjob]

The closest thing I could see is there was a textbox_behavior.mixin.js calling the getMinWidth() method (or just the variable prior). This file was deleted here: 21fb0c3#diff-fc67e1b703e3630e32dade17d9729e1b0475591ce6c5e2c710ac73436aa4a5a8

However, looking above the deleted file, you see references to an instanceof fabric.Textbox (without casting) that call the getMinWidth() property on such an object. So the reality is that it is being used, although where it is is obscure and how it's working may be questionable? Hopefully Typescript makes a little clear that this method is being used.

[ShaMan123]

so strange

[ShaMan123]

same in 4.6
so I believe is OK