Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabricjs 2.0 Text decoration #4555

Closed
DangerD256 opened this issue Dec 12, 2017 · 6 comments
Closed

Fabricjs 2.0 Text decoration #4555

DangerD256 opened this issue Dec 12, 2017 · 6 comments
Labels

Comments

@DangerD256
Copy link
Contributor

2.0

Test Case

https://jsfiddle.net/bLn363j1/1/

Can't set underline/overline/line-through...
Worked well in 1.x

@asturur asturur added the docs label Dec 12, 2017
@asturur
Copy link
Member

asturur commented Dec 12, 2017

i cannot find the notice in any docs.

you have to use underline: true/false , overline:true/false, line-trough: true/false

@DangerD256
Copy link
Contributor Author

DangerD256 commented Dec 14, 2017

line-through: true/false - doesn't work

... Where i can post feature request?

@samael205
Copy link

Please read the FabricJS Docs

http://fabricjs.com/docs/fabric.IText.html

You must use canvas.getActiveObject().set("linethrough", true);

@darron1217
Copy link

Doc says its type is String but actually it accepts boolean
Doc should be fixed

/**
* Text decoration underline.
* @type String
* @default
*/
underline: false,
/**
* Text decoration overline.
* @type String
* @default
*/
overline: false,
/**
* Text decoration linethrough.
* @type String
* @default
*/
linethrough: false,

durga598 pushed a commit to durga598/fabric.js that referenced this issue Jul 14, 2018
asturur pushed a commit that referenced this issue Jul 14, 2018
* Added callback in setPatternFill

As Pattern constructor taking callback, we can use it.

* doc changed #4555

* jsdoc @link added in setCoords
durga598 pushed a commit to durga598/fabric.js that referenced this issue Jul 14, 2018
@pidugusundeep
Copy link

linethrough:True works just fine for me

thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this issue Nov 18, 2019
* Added callback in setPatternFill

As Pattern constructor taking callback, we can use it.

* doc changed fabricjs#4555

* jsdoc @link added in setCoords
@asturur
Copy link
Member

asturur commented Feb 8, 2021

Just in case someone can still hit this issue, i updated the official doc with a note.

http://fabricjs.com/fabric-text

@asturur asturur closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants