Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow limited use of type annotations #6322

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

shawkins
Copy link
Contributor

Description

Allows Pattern, Min, and Max to be specified on List or Map component types. This initial version looks specifically for List and Map types - this may be too restrictive, but it keeps the logic simplier. If there is a method as the annotatedmember, it will use the same simple logic as the validation rules to find the field.

I also commented out getting the minLength / maxLength from the string schema for the min / max - that is currently not used and it's not correct as minLength / maxLength are distinct and set specfically for strings.

cc @adriansuarez

closes: #6282

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

closes: fabric8io#6282

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 7.0.0 milestone Sep 16, 2024 — with automated-tasks
Copy link

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit cc33729 into fabric8io:main Sep 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRDGenerator: Cannot specify @Pattern annotation on type parameter
2 participants