Skip to content

fix (openshift-client) : OpenShiftOAuthInterceptor should not refresh on 403 response code (#4970) #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix (openshift-client) : OpenShiftOAuthInterceptor should not refresh on 403 response code (#4970) #4973

merged 1 commit into from
Mar 20, 2023

Conversation

@rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Mar 15, 2023 •
edited by manusa
Loading

Description

Fix #4970

Do not do token refresh on HTTP_FORBIDDEN response code in order to align better with kubectl and oc

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia
fix (openshift-client) : OpenShiftOAuthInterceptor should not refresh…
7b9de5b 
… on `403` response code (fabric8io#4970)

Do not do token refresh on HTTP_FORBIDDEN response code in order to
align better with kubectl and oc

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia marked this pull request as ready for review March 17, 2023 05:47
shawkins
shawkins approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manusa manusa added this to the 6.6.0 milestone Mar 20, 2023
@manusa manusa merged commit 700dab3 into fabric8io:master Mar 20, 2023
@rohanKanojia rohanKanojia deleted the pr/issue4970 branch March 20, 2023 08:33
@manusa manusa modified the milestones: 6.6.0, 6.5.1 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manusa manusa manusa approved these changes

@shawkins shawkins shawkins approved these changes

@sunix sunix Awaiting requested review from sunix

+1 more reviewer

@oscerd oscerd oscerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.5.1

Development

Successfully merging this pull request may close these issues.

OpenShiftOAuthInterceptor should not refresh on 403 response code

4 participants

@rohanKanojia @manusa @shawkins @oscerd