Skip to content

fix #4201: moving consumeLines out of the clients #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manusa merged 1 commit into from
Nov 30, 2022
Merged

fix #4201: moving consumeLines out of the clients #4619

manusa merged 1 commit into from
Nov 30, 2022

Conversation

@shawkins
Copy link
Contributor

@shawkins shawkins commented Nov 29, 2022

Description

Follow up to #4430 that moves consumeLines directly to the http watch.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested a review from manusa November 29, 2022 16:40
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

13.3% 13.3% Coverage
0.0% 0.0% Duplication

@shawkins shawkins mentioned this pull request Nov 29, 2022
Closed
@manusa manusa merged commit b743b2f into fabric8io:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manusa manusa manusa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shawkins @manusa