Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing OpenShift Resources in authorization.openshift.io apiGroup in OpenShiftClient DSL #3133

Merged

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented May 17, 2021

Description

Add DSL support for the following resources:

  • ResourceAccessReview : client.resourceAccessReviews()
  • LocalSubjectAccessReview : client.localSubjectAccessReviews()
  • ClusterRole : client.clusterRoles()
  • LocalResourceAccessReview : client.localResourceAccessReviews()
  • SubjectRulesReview : client.subjectRulesReviews()
  • SelfSubjectRulesReview : client.selfSubjectRulesReviews()
  • RoleBindingRestrictions: client.roleBindingRestrictions()

Related to #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@rohanKanojia rohanKanojia force-pushed the pr/openshift-model-authorization branch from 980274c to 1d4ce9a Compare May 17, 2021 15:51
@rohanKanojia rohanKanojia changed the title Add missing OpenShift Resources in authorization.openshift.io apiGroup Add missing OpenShift Resources in authorization.openshift.io apiGroup in OpenShiftClient DSL May 17, 2021
@rohanKanojia rohanKanojia force-pushed the pr/openshift-model-authorization branch from 1d4ce9a to cc3e4e5 Compare May 17, 2021 16:20
Add DSL support for the following resources:
- ResourceAccessReview : `client.resourceAccessReviews()`
- LocalSubjectAccessReview : `client.localSubjectAccessReviews()`
- ClusterRole : `client.cluserRoles()`
- LocalResourceAccessReview : `client.localResourceAccessReviews()`
- SubjectRulesReview : `client.subjectRulesReviews()`
- SelfSubjectRulesReview : `client.selfSubjectRulesReviews()`
- RoleBindingRestrictions: `client.roleBindingRestrictions()`

Related to fabric8io#2949
@manusa manusa force-pushed the pr/openshift-model-authorization branch from cc3e4e5 to cdf9869 Compare May 20, 2021 05:20
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2021

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit ed08377 into fabric8io:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants