Default annotation not working as expected

[raminqaf]

Describe the bug

I am using the new Default annotation to generate my CRDs with defaults. My spec class looks like this:

@Data
@Jacksonized
@Builder
public class MyAppSpec {
        @Required
        private String name;
        @Default("1")
        private int replicaCount;
        @Required
        private String image;
        @Required
        private String imageTag;
        @Default("Always")
        private String imagePullPolicy;
        @Default("false")
        private boolean deployment;
}

And the generated CRD is missing the default values. The output looks like this:

apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: myapps.com.organisation.tree
spec:
  group: com.organisation.tree
  names:
    kind: MyApp
    plural: myapps
    singular: myapp
  scope: Namespaced
  versions:
  - name: v1
    schema:
      openAPIV3Schema:
        properties:
          spec:
            properties:
              deployment:
                type: boolean
              image:
                type: string
              imagePullPolicy:
                type: string
              imageTag:
                type: string
              name:
                type: string
              replicaCount:
                type: integer
            required:
            - name
            - image
            - imageTag
            type: object
          status:
            properties:
              ready:
                type: boolean
            type: object
        type: object
    served: true
    storage: true
    subresources:
      status: {}

Fabric8 Kubernetes Client version

6.9.0

Steps to reproduce

1. Create a spec POJO
2. Annotate fields with @Default
3. Generate the CRD

Expected behavior

To have default field in the generated CRD

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.25.3@latest

Environment

macOS

Fabric8 Kubernetes Client Logs

No response

Additional context

No response

[manusa]

/cc @andreaTP

[andreaTP]

Looking at this, it might be related to the usage @Data and/or @Builder, meanwhile @raminqaf would you mind trying to apply the @Default annotation on an explicit getter?

Something along those lines:

@Data
@Jacksonized
@Builder
public class MyAppSpec {
        @Required
        private String name;
        private int replicaCount;
        @Required
        private String image;
        @Required
        private String imageTag;
        private String imagePullPolicy;
        private boolean deployment;

        @Default("1")
        public int getReplicaCount() {
          return this.replicaCount;
        }
        
        @Default("false")
        public boolean getDeployment() {
          return this.deployment;
        }

        @Default("Always")
        public String getImagePullPolicy() {
          return this.imagePullPolicy;
        }

}

[andreaTP]

Tested in the test-suite and it's working as expected:
main...andreaTP:kubernetes-client:repro-5501

The problem is likely to happen because of the interaction between the multiple annotation processors (IIRC @shawkins has been looking into this).

@raminqaf would you be able to provide a complete reproducer (dependencies included)?

[shawkins]

Seems similar to #4934 - I don't recall any resolution there, just that we had to be more explicit rather than using lombok. I don't believe there is any good way to force the ordering of annotation processors unfortunately.

[andreaTP]

thanks for the feedback @shawkins , let's see if @raminqaf finds a viable workaround.

[raminqaf]

@andreaTP Thanks for the suggestion. I tried it out, but it didn't work out. I removed the @Builder and @Jacksonized annotations and kept only the @Data one, but still had the same problem.

[andreaTP]

Thanks for the feedback @raminqaf , found the bug and fixed 👍
Basically @Data is emitting multiple property accessors, and the value of Default was getting overridden by null.