Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-generator] Improve the docs to include examples of the options #5285

Open
andreaTP opened this issue Jun 26, 2023 · 28 comments
Open

[java-generator] Improve the docs to include examples of the options #5285

andreaTP opened this issue Jun 26, 2023 · 28 comments

Comments

@andreaTP
Copy link
Member

Is your enhancement related to a problem? Please describe

Currently, the docs are listing the available options for the plugins and the CLI, but there are no examples of "how to use them" and the expected output.

Describe the solution you'd like

We should describe the available options and include snippets of the usage and how it affects the generation.

Describe alternatives you've considered

No response

Additional context

No response

@andreaTP andreaTP added help wanted good first issue Easy hack; Good issue for new contributors labels Jun 26, 2023
@g1rjeevan
Copy link

/assign

@shubhamvrs
Copy link

/assign

@rohanKanojia rohanKanojia assigned shubhamvrs and unassigned g1rjeevan Aug 4, 2023
@shubhamvrs

This comment was marked as off-topic.

@andreaTP
Copy link
Member Author

andreaTP commented Aug 7, 2023

Hi @shubhamvrs and thanks for your interest!

To complete this task we do expect a PR expanding this section of the current docs:
https://github.com/fabric8io/kubernetes-client/blob/main/doc/java-generation-from-CRD.md#usage

Would you be able to provide it?

@shubhamvrs
Copy link

shubhamvrs commented Aug 7, 2023

i tried my best sir but im unable to create it actually im new to github thatswhy !

@rohanKanojia
Copy link
Member

@shubhamvrs : Could you please elaborate? What problem are you facing?

@shubhamvrs
Copy link

shubhamvrs commented Aug 8, 2023

@rohanKanojia im not able to provide a PR expanding this section: ( https://github.com/fabric8io/kubernetes-client/blob/main/doc/java-generation-from-CRD.md#) usage of the current docs that i have created previously

@rohanKanojia
Copy link
Member

@shubhamvrs : Do you mean you don't have enough knowledge about java generator to improve existing documentation?

@shubhamvrs
Copy link

im unable to create new file in given format with given path in new pull request

@rohanKanojia
Copy link
Member

@shubhamvrs : Why is that so? Are you getting some error?

@shubhamvrs
Copy link

@rohanKanojia its just im unable to create a file on given format. I have the doc but file needs to be converted in given format !

@rohanKanojia
Copy link
Member

I'm not able to understand what you're saying. Which document are you talking about?

@shubhamvrs

This comment was marked as off-topic.

@shubhamvrs
Copy link

@rohanKanojia

@rohanKanojia
Copy link
Member

@shubhamvrs : This doesn't look correct to me. You need to add examples of options of CLI and maven plugin. Users won't be using JavaGenerator class directly. You need to add example output as well.

I'm afraid working with this issue requires knowledge about Kubernetes, Custom Resources, and maven. I think it is not a good fit for your skills.

@shubhamvrs
Copy link

@rohanKanojia okayy

@rohanKanojia
Copy link
Member

@shubhamvrs : Please don't get discouraged by my comment. You're still welcome to contribute. But perhaps you should start with something really simple as a first contribution (maybe correcting grammar mistakes, fixing/improving tests, etc)

@shubhamvrs
Copy link

@rohanKanojia sure sir i will😊

@AlishRani
Copy link

/assign

1 similar comment
@heralgi
Copy link

heralgi commented Sep 12, 2023

/assign

@manusa
Copy link
Member

manusa commented Sep 21, 2023

Note, there is no bot controlling the issue assignment so `/assign' won't work.

If you're willing to work on the issue, just ask so politely 🙂

Also, make sure to understand what's requested and how to proceed. We might assist you a little, but we do expect a minimum knowledge of what you're handling here.

@Mandeep56Singh
Copy link

i want to contribute to this repo , i only know java .
Which other things do i need to know in order to contribute ( good contribution)
Please help, I am beginner in open source contribution

@Mandeep56Singh
Copy link

I will learn whatever needed to shut down this issue .
I just need your help .

@andreaTP
Copy link
Member Author

andreaTP commented Oct 1, 2023

@Mandeep56Singh this is the expectation:
#5285 (comment)

Let us know if you have further questions.

@Mandeep56Singh
Copy link

@andreaTP could you please tell
what knowledge should I have to work on this issue ?
I only know java ( mostly for algorithms)

@andreaTP
Copy link
Member Author

andreaTP commented Oct 2, 2023

#5285 (comment)

Copy link

stale bot commented Jan 2, 2024

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

@stale stale bot added the status/stale label Jan 2, 2024
Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants