-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JUnit5 org.junit.jupiter:junit-jupiter-migrationsupport
dependency from codebase
#5141
Labels
Comments
can i work on this |
@rohanKanojia after removing the org.junit.jupiter:junit-jupiter-migrationsupport dependency I got an error with the Maven test |
@Akshaya-hub : Are you getting error in UberJarTest? You can try replacing TemporaryFolder Rule there with |
@rohanKanojia ok i will try |
manusa
added
technical-debt
good first issue
Easy hack; Good issue for new contributors
labels
May 30, 2023
degant
added a commit
to degant/kubernetes-client
that referenced
this issue
May 31, 2023
…ndency from codebase
11 tasks
manusa
pushed a commit
that referenced
this issue
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Is your task related to a problem? Please describe
We seem to be including this dependency in most of our poms:
kubernetes-client/pom.xml
Lines 837 to 841 in c76762a
I think it was added during JUnit5 refactor to maintain compatibility with JUnit4
@Rule
, when mockserver had to be used with a@Rule
. But now that we've migrated to JUnit5 extension@EnableKubernetesMockServer
. This dependency should not be required.I only see one place where we're using
@Rule
in a JUnit5 test, but it can easily be replaced with@TempDir
JUnit5 annotation:kubernetes-client/uberjar/src/test/java/io/fabric8/kubernetes/clnt/UberJarTest.java
Lines 49 to 50 in c76762a
You can find all the occurrences of this dependency by searching for
junit-jupiter-migrationsupport
in project.Describe the solution you'd like
Remove all occurrences of
org.junit.jupiter:junit-jupiter-migrationsupport
dependency. For most places, it should be as trivial as removing the dependency from pom.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: