This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
feat : Add Fabric8 Maven Plugin deprecation log message before & after goal executions #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanKanojia
force-pushed
the
pr/issue1426
branch
7 times, most recently
from
63f2fb6
to
1147d1b
Compare
manusa
suggested changes
Jun 9, 2022
core/src/main/java/io/fabric8/maven/core/util/Fabric8MavenPluginDeprecationUtil.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/fabric8/maven/core/util/Fabric8MavenPluginDeprecationUtil.java
Outdated
Show resolved
Hide resolved
|
@sunix could you please take a look |
|
do we want to do this now or in a next release/pr?
|
I cannot add myself as a reviewer |
That would be a period (3-6 months) after we release these changes |
😄 yes, that's why I pinged you in a message. But you should be able to provide a review or comment an LGTM |
rohanKanojia
force-pushed
the
pr/issue1426
branch
from
1147d1b
to
43e2dfe
Compare
sunix
suggested changes
Jun 13, 2022
| } | ||
|
|
||
| @Test | ||
| public void logFabric8MavenPluginDeprecation_whenLogDeprecationFalse_shouldLogDeprecationWarning() { |
There was a problem hiding this comment.
..._shouldLogDeprecationWarning or ..._shouldNotLogDeprecationWarning ?
rohanKanojia
force-pushed
the
pr/issue1426
branch
from
43e2dfe
to
2f6861e
Compare
manusa
reviewed
Jun 13, 2022
| @@ -2,6 +2,11 @@ | |||
| [[introduction]] | |||
| = Introduction | |||
|
|
|||
| IMPORTANT: *Fabric8 Maven Plugin is deprecated and is no longer be supported. | |||
There was a problem hiding this comment.
Suggested change
| IMPORTANT: *Fabric8 Maven Plugin is deprecated and is no longer be supported. | |
| IMPORTANT: *Fabric8 Maven Plugin is deprecated and is no longer supported. |
…r goal executions Related to eclipse-jkube/jkube#1426 Add warning log message to print deprecation message and instruct users to migrate to Eclipse JKube Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue1426
branch
from
2f6861e
to
cec4df6
Compare
manusa
approved these changes
Jun 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to eclipse-jkube/jkube#1426
Add warning log message to print deprecation message and instruct users
to migrate to Eclipse JKube
Signed-off-by: Rohan Kumar rohaan@redhat.com