Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

HTML/CSS: Cleanup on Feature Flags #837

Closed
AdamJ opened this issue Jan 22, 2018 · 3 comments
Closed

HTML/CSS: Cleanup on Feature Flags #837

AdamJ opened this issue Jan 22, 2018 · 3 comments
Assignees
@AdamJ
Labels
code/HTML&CSS implementation of HTML/CSS
Milestone
Sprint 143-3

Comments

@AdamJ
Copy link
Collaborator

AdamJ commented Jan 22, 2018

Review the Feature Flags updates that have been done to fabric8-ui. Update HTML/CSS to match designs.
@AdamJ AdamJ added the code/HTML&CSS implementation of HTML/CSS label Jan 22, 2018
@AdamJ AdamJ added this to the Sprint 143-3 milestone Jan 22, 2018
@AdamJ AdamJ self-assigned this Jan 22, 2018
@catrobson catrobson mentioned this issue Jan 22, 2018
Open
12 tasks
@AdamJ
Copy link
Collaborator Author

AdamJ commented Jan 22, 2018

Issues to resolve:

@AdamJ
Copy link
Collaborator Author

AdamJ commented Jan 22, 2018

Updated the .btn-feature-level styles to use proper gradients and implemented the :hover styles. Fixed a spelling error in the .btn-experimental class for the banner that caused the styles to not be applied.

AdamJ added a commit to AdamJ/fabric8-ui that referenced this issue Jan 22, 2018
@AdamJ
fix(flags): Update Feature Flag styles
3c6aa15 
Update the Feature Flag styles to include gradient backgrounds for the opt-in button, add hover styles; update class spelling error so that proper styles are applied.

related to:
- fabric8-ui/fabric8-ux#837
- openshiftio/openshift.io#1955
- openshiftio/openshift.io#1956
@AdamJ AdamJ mentioned this issue Jan 22, 2018
Merged
corinnekrych pushed a commit to fabric8-ui/fabric8-ui that referenced this issue Jan 23, 2018
@AdamJ @corinnekrych
fix(flags): Update Feature Flag styles (#2428)
4e6fc7a 
Update the Feature Flag styles to include gradient backgrounds for the opt-in button, add hover styles; update class spelling error so that proper styles are applied.

related to:
- fabric8-ui/fabric8-ux#837
- openshiftio/openshift.io#1955
- openshiftio/openshift.io#1956
@corinnekrych
Copy link
Member

fixed with fabric8-ui/fabric8-ui#2428 @mindreeper2420 pls close it

@AdamJ AdamJ closed this as completed Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AdamJ AdamJ

Labels
code/HTML&CSS implementation of HTML/CSS
Projects
None yet
Milestone
Sprint 143-3
Development

No branches or pull requests
2 participants
@corinnekrych @AdamJ