Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Don't call auth service for user's OpenShift username #610

Closed
wants to merge 1 commit into from

Conversation

surajssd
Copy link
Contributor

@surajssd surajssd commented Jun 21, 2018

Now that we have the user's OpenShift username stored in the tenant's
database, now we can stop calling auth and directly fetch it from the
database.

Fixes openshiftio/openshift.io#2635

Now that we have the user's OpenShift username stored in the tenant's
database, now we can stop calling auth and directly fetch it from the
database.
@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @surajssd for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@fabric8cd
Copy link
Contributor

@surajssd snapshot fabric8-tenant image is available for testing. docker pull docker.io/fabric8/fabric8-tenant:SNAPSHOT-PR-610-1

@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #610 into master will increase coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #610      +/-   ##
=========================================
+ Coverage   35.25%   35.4%   +0.15%     
=========================================
  Files          31      31              
  Lines        2096    2087       -9     
=========================================
  Hits          739     739              
+ Misses       1268    1259       -9     
  Partials       89      89
Impacted Files Coverage Δ
controller/tenant.go 12.5% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e27d4...87113d8. Read the comment docs.

@alexeykazakov
Copy link
Contributor

Please add tests.

@surajssd surajssd closed this Sep 7, 2018
@surajssd surajssd deleted the stop-calling-auth branch September 7, 2018 07:28
@fabric8cd
Copy link
Contributor

@surajssd snapshot fabric8-tenant image is available for testing. docker pull docker.io/fabric8/fabric8-tenant:SNAPSHOT-PR-610-2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants