Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for metadata removal: GDPR compliance #322

Closed
chmouel opened this issue Oct 18, 2018 · 7 comments
Closed

API for metadata removal: GDPR compliance #322

chmouel opened this issue Oct 18, 2018 · 7 comments
Assignees

Comments

@chmouel
Copy link
Contributor

chmouel commented Oct 18, 2018

Provide an API which effectively do those SQL queries :

Find the jenkins namespace associated with the user - say ${user_jenkins_namespace}

DELETE FROM statistics WHERE namespace = '${user_jenkins_namespace}';
DELETE FROM requests WHERE namespace = '${user_jenkins_namespace}';

https://openshift.io/openshiftio/Openshift_io/plan/detail/805

@kishansagathiya
Copy link
Member

@chmouel Thinking of picking this up
how about
DELETE https://localhost:9091/api/metadataremoval/$namespace

@chmouel
Copy link
Contributor Author

chmouel commented Oct 29, 2018

what about /api/clear/metadata/${namespace} ?

@kishansagathiya
Copy link
Member

@chmouel /api/clear/metadata/${namespace} seems more appropriate

@kishansagathiya
Copy link
Member

kishansagathiya commented Nov 26, 2018

@chmouel I see a function to soft delete requests. I can't imagine why we would need this info in future(except for doing some analytics). I am inclined towards not keeping separate soft-delete and hard-delete function, and just hard-delete them both.
Let me know if you think I should keep soft-delete

Don't see deleted_at column

@kishansagathiya kishansagathiya self-assigned this Nov 26, 2018
@kishansagathiya
Copy link
Member

hhmm, this would require authorization header as well as well, and then we won't need to pass namespace parameter

@chmouel
Copy link
Contributor Author

chmouel commented Nov 26, 2018

sounds good 👍

kishansagathiya added a commit to kishansagathiya/fabric8-jenkins-proxy that referenced this issue Nov 26, 2018
Provide an API which effectively do those SQL queries :

Find the jenkins namespace associated with the user,
say ${user_jenkins_namespace}

```
DELETE FROM statistics WHERE namespace = '${user_jenkins_namespace}';
DELETE FROM requests WHERE namespace = '${user_jenkins_namespace}';
```

Fixes fabric8-services#322
@kishansagathiya
Copy link
Member

kishansagathiya commented Nov 27, 2018

Task list

curl -X DELETE http://localhost:9091/api/clear/metadata/ksagthi-preview-jenkins -H "Authorization: Bearer $SERVICE_ACCOUNT_TOKEN"

@sbose78 Can you verify if above is the expected API structure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants