WIP: Add debug tools #279
WIP: Add debug tools #279
Conversation
Gopkg.lock
Outdated
| @@ -262,13 +323,32 @@ | |||
| "pkg/util/validation/field", | |||
| "pkg/util/wait", | |||
| "pkg/watch", | |||
| "third_party/forked/golang/reflect" | |||
| "third_party/forked/golang/reflect", | |||
There was a problem hiding this comment.
Is , an automated change?
There was a problem hiding this comment.
I will not check in the Gopkg.lock file. It isn't needed for this commit
| @@ -70,6 +74,8 @@ tools.timestamp: | |||
| go get -u github.com/vbatts/git-validation/... | |||
| go get -u github.com/goadesign/goa/goagen | |||
| go get -u github.com/haya14busa/goverage | |||
| go get -u github.com/golangci/golangci-lint/cmd/golangci-lint | |||
There was a problem hiding this comment.
Humm wanna use it somewhere?
There was a problem hiding this comment.
yes, it works locally quite well with syntastic and vim
There was a problem hiding this comment.
api.go
type idler struct {
userIdlers *openshift.UserIdlerMap
clusterView cluster.View
openShiftClient client.OpenShiftClient
✗ controller openshift.Controller // not used anywhere
tenantService tenant.Service
}
There was a problem hiding this comment.
yes right i mean in a makefile target like this for example :
https://github.com/fabric8-services/fabric8-build-service/blob/master/Makefile#L176
Ike Plugins (test-keeper)Thank you @sthaha for this contribution!
It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin. |
No description provided.