-
Notifications
You must be signed in to change notification settings - Fork 5
add capacity_exhausted to cluster table #29
Conversation
528d9aa
to
50f7cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests adjustments for the new flag?
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 75.83% 75.62% -0.22%
==========================================
Files 12 12
Lines 716 718 +2
==========================================
Hits 543 543
- Misses 142 143 +1
- Partials 31 32 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor comment, otherwise, it looks good to me 👍
@@ -0,0 +1,2 @@ | |||
-- Store capacity_exhausted for cluster | |||
ALTER TABLE cluster ADD COLUMN capacity_exhausted boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add DEFAULT false
to the column definition, for existing clusters in the DB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 651123b
Changes proposed in this PR
capacity_exhausted
column to cluster table