This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
add capacity_exhausted to cluster table #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipak-pawar
force-pushed
the
cluster_cap
branch
from
528d9aa
to
50f7cba
Compare
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 75.83% 75.62% -0.22%
==========================================
Files 12 12
Lines 716 718 +2
==========================================
Hits 543 543
- Misses 142 143 +1
- Partials 31 32 +1
Continue to review full report at Codecov.
|
xcoulon
approved these changes
Nov 22, 2018
| @@ -0,0 +1,2 @@ | |||
| -- Store capacity_exhausted for cluster | |||
| ALTER TABLE cluster ADD COLUMN capacity_exhausted boolean; | |||
There was a problem hiding this comment.
maybe add DEFAULT false to the column definition, for existing clusters in the DB?
There was a problem hiding this comment.
addressed in 651123b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
capacity_exhaustedcolumn to cluster table