This repository has been archived by the owner on May 6, 2021. It is now read-only.
Implement #17 Fetch public keys from auth service #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
changed the title
chmouel
added
the
work-in-progress🏋️♀️
chmouel
changed the title
alien-ike
removed
the
work-in-progress🏋️♀️
chmouel
added
the
work-in-progress🏋️♀️
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 34.18% 43.89% +9.71%
==========================================
Files 4 8 +4
Lines 354 647 +293
==========================================
+ Hits 121 284 +163
- Misses 222 316 +94
- Partials 11 47 +36
Continue to review full report at Codecov.
|
chmouel
added
feature🧁
|
Note: will use pr description as final squash and merge description |
Maybe we want to do the whole docker/minishift thing in the future but we are not there yet.
I wish we just had that from a common repo. Was using the repo files directly but I don't think this was right as this is a private thing to repo,
So it shows nicely on make help
Probably could find a way to exclude having comments on exported functions for tests,
And improve CI to run make docker-run and check that ports are up! (should be quick anyway) Remove those stupid sleeps along the way,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #17 by getting the keys from the auth service.
Most of the code and tests has been imported from
fabric8-tenantA few things has been added along this.