This repository has been archived by the owner on May 6, 2021. It is now read-only.
Set viper config to our own, or this will crash #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 28.03% 26.55% -1.49%
==========================================
Files 4 4
Lines 321 354 +33
==========================================
+ Hits 90 94 +4
- Misses 219 248 +29
Partials 12 12
Continue to review full report at Codecov.
|
Binary was not running due of bad usage of composition between common class. After chatting with the -common people, it seems that configuration from common is getting removed, so let's instead use our own and only pickup the stuff we need to run the service + db.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fabric8-services/fabric8-common#22
Fix #18