-
Notifications
You must be signed in to change notification settings - Fork 0
Adds NodeProcessingStatus #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-from-nodedelegatemodel Add UI update signal
tatatupi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon is too small:
And I didn't understand why you included the struct NodeProcessingStatus inside the NodeDelegateModel. I removed it from it, leaving the struct at the same "level" as NodeValidationState.
However, I don't know if it needs to be a struct, as the Validation State, and not directly an enum class. Why did you choose the struct?
|
I have fixed the conflicts, however. Soon it will be available for merge request in paceholder |
|
Now, to address these example issues, the following changes were made:
And, to explain the appearance of the Error processing status, there is a conditional statement that change the control flow when the first input for the node (the top one) is greater than the second input (the bottom one), so that the Error processing status can also be displayed and seen as a processing status option by the PR reviewer. The conditional statement is as follows: So, the goal is to keep a random number being generated in the range [a,b] ([n1, n2]), as described in the Random Number node class docstring. These control flow details will be explained in the final nodeeditor PR! |



This PR adds the node processing status dynamic that was present in nodeeditor v1. It has now been updated to seamlessly adapt to nodeeditor v3. It also contains an example to illustrate this updated dynamic.