Skip to content

Support for ActiveAdmin 1.0 and 1.1.0#25

Merged
fabn merged 9 commits intofabn:developfrom
rhymes:aa-110
Oct 3, 2017
Merged

Support for ActiveAdmin 1.0 and 1.1.0#25
fabn merged 9 commits intofabn:developfrom
rhymes:aa-110

Conversation

@rhymes
Copy link

@rhymes rhymes commented Aug 28, 2017

No description provided.

@fabn
Copy link
Owner

fabn commented Sep 6, 2017

Thanks for your PR, are you interested in becoming a maintainer of this project?

See #26

s.files = Dir['{app,config,db,lib}/**/*'] + %w(MIT-LICENSE README.md)

s.add_dependency 'activeadmin'
s.add_dependency 'activeadmin', '>= 1.0', '< 1.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhymes Here you could do < 1.2 to support ActiveAdmin 1.1

@besi
Copy link

besi commented Oct 2, 2017

I did try a fork of your branch with Activeadmin 1.1 and it worked fine so far:

screen shot 2017-10-02 at 22 11 57

screen shot 2017-10-02 at 22 12 35

screen shot 2017-10-02 at 22 12 51

screen shot 2017-10-02 at 22 12 43

The only problem I currently faced is that I sometimes have only a German flag and sometimes an English and a German flag for entries that, in both cases, only had an English translation.

So you might consider to support ActiveAdmin 1.1 while you're at it.

Please note that the background on the screenshots comes from my custom css.

@rhymes
Copy link
Author

rhymes commented Oct 3, 2017

@besi you're right. I've allowed AA 1.1. The issue is that this branch (as the upstream branch) does not remotely pass any test on Travis :-(

@fabn fabn mentioned this pull request Oct 3, 2017
@fabn fabn merged commit 1d9d553 into fabn:develop Oct 3, 2017
@fabn
Copy link
Owner

fabn commented Oct 3, 2017

Thanks for your PR, since you and others reported it to work I've merged it and I'm going to release it as version 1.0.0.pre

I'm about to push it to rubygems.

@fabn
Copy link
Owner

fabn commented Oct 3, 2017

Version 1.0.0.pre is out

@rhymes rhymes deleted the aa-110 branch October 4, 2017 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants