-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install extensions as console_scripts #173
base: main
Are you sure you want to change the base?
Conversation
c962733
to
02ca76f
Compare
While the current default installation method is to install the files as a Inkscape Extension...
I'd like to concentrate this PR to changes [2] and [3].
__ May I ask: will the changes [part 2]
It would be great to know how these changes support solving some nasty snap related path issues for inkscape in the future i.e. via deploying the extension for the extension manager... Thanks for clarification. PS: In case we choose to abandon the current dual installation possibilities and switch to solely pip install method then we need to ensure it will apply everywhere in the right context (system vs. user: i.e.
Line 37 in 5a19eb4
inkscape-silhouette/install_osx.py Line 18 in 5a19eb4
Lines 40 to 42 in 5a19eb4
Line 112 in 5a19eb4
etc. ... |
@t0b3 thx a lot for your feedback! You are right that my PR basically consists of 3 parts (setup.py, console-scripts, installation scripts).
Fine by me. I'll remove the setup.py changes and create a separate PR for them once parts 2 and 3 are merged.
I think it is possible to extend setup.py to install the inx file to the desired location e.g. into the home directory of the user ( I just had a look at two extensions that are part of the inkscape-extension-store: https://gitlab.com/inkscape/extras/inkscape-import-clipart but none of them use setup.py to install the extension. I'll look further - maybe I can find an extension that has already solved the installation/deployment problem. |
In order to simplify and generalize the installation instructions, we could bundle all files (inkscape extension + python library) into a python pkg, which can be installed using |
The two scripts (silhouette_multi.py and sendto_silhouette.py) are now part of the `silhouette` python pkg and the executables are created and installed by setuptools (see the defined console scripts in setup.py). Furthermore the pytest related code from setup.py was removed, because the `test` subcommand of `setup.py` is deprecated.
They will be done in a separate PR.
@t0b3 I've removed the setup.py changes from this PR as you suggested. In a separate PR I'll create a new console script that allows the users copy the inx files into the desired extension directory. This would allows us to simplify the installation instructions. WDYT? |
Which use case will this PR contribute to? Is this PR suggesting to install the inkscape extension via If yes
and for which OS and which steps do you feel do the installation instructions sound complicated? |
Since a
setup.py
file exists in the src tree, it should also be used for the installation, which is currently not the case if one follows the instructions in the README. The README says that the requires files should be copied into the inkscapeextensions
directory. IMO the files in thesilhouette
directory should be properly installed and executables of the two extensions should be created, which should be used in theinx
files.This is done in this PR. Furthermore the pytest related code from setup.py was removed, because
the
test
subcommand ofsetup.py
is deprecated.