adding new author

[HansUwe52]

There is a new problem, when I want to add a new author to a new record.

On the page: /admin/libri/crea I have filled out the fields: Title, Subtitle, Publication Year, Language and Publisher

Then I want to add a new author and click on the author field and write the name: Norbert Wex, with it not in the database. The dropdownlist shows me existing authors with the first name Norbert. Behind the name Norbert Bauer there is the note "Click to select"

When I hit Enter Pinakes chooses Norbert Bauer and my new name Norbert Wex is not added to the author list.

Right now I only can add new authors by going to the page Authors Management.

Afterwards I can go back to my new record and choose the new author from the drop down list

[fabiodalez-dev]

Hi @HansUwe52!

The issue has been identified and fixed. When you typed a new author name (e.g., "Norbert Wex") and pressed Enter, Choices.js was automatically selecting the first highlighted match from the dropdown (e.g., "Norbert Bauer") instead of creating the new author.

Root cause: Choices.js v11 registers its Enter key handler in the capture phase on the outer wrapper element, so it fires before any custom handler on the input field. When a dropdown item is highlighted (which happens automatically during search), pressing Enter always selects that highlighted item — regardless of whether it matches what the user actually typed.

Fix: I now override Choices.js's internal _onEnterKey method to check whether the highlighted item actually matches the typed text. If it doesn't match, the new author is created instead. If it does match (exact or prefix), the existing author is selected as expected.

Both behaviors are now covered by automated tests. The fix will be included in the next release.

Thanks for the detailed report with screenshots — it made the issue very easy to reproduce!

[fabiodalez-dev]

This was fixed and is confirmed working in v0.4.9.4. Adding a new author now works correctly with the Choices.js autocomplete — typing an author name shows matching suggestions, and selecting one properly populates the field. Creating a brand new author that doesn't exist yet also works as expected.

This is covered by E2E test 7.6 ("Autocomplete regression #58, #74") which verifies the author autocomplete returns results and allows selection.

Relevant commit: 1cdc675 — fix: issue #74 author autocomplete, #76 digital file badges, #77 export selected

Latest release: https://github.com/fabiodalez-dev/Pinakes/releases/tag/v0.4.9.4

[HansUwe52]

the problem regarding adding a new author as described in this issue is back in the current version.

[fabiodalez-dev]

Hi @HansUwe52, you're right — the bug regressed.

Root cause of the regression: an internal code-review pass (commit e976cb1, "round 11") replaced the original monkey-patch on authorsChoice._onEnterKey with what looked like a "cleaner" capture-phase keydown listener on the wrapper. Unfortunately Choices.js v11 registers its OWN capture-phase keydown handler on the same wrapper inside new Choices(…), BEFORE our code runs, and calls stopImmediatePropagation() on Enter when there's a highlighted item — so our listener never sees the event, and the dropdown's highlighted item wins (the "Norbert Bauer" / "Norbert Wex" behaviour you re-reported).

Fix: restored the per-instance monkey-patch on _onEnterKey (the same approach that was confirmed working in v0.4.9.4), with a defensive fallback to the capture-phase listener for any future Choices.js version that removes the method. Per-instance override only — publisher/genre/etc. Choices instances on the same page keep stock behaviour.

Landed on main at commit 8482b53d.

To verify: open /admin/libri/crea, type a new author name that partially matches an existing one (e.g. start with "Norbert" if you have a "Norbert Bauer" in the DB), then press Enter — it should now create the new author from your typed text instead of selecting the existing match. The existing-match selection still works when you type a name that exactly matches the highlighted item.

Sorry for the regression and thanks for catching it!