Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select support added for react-query components #83

Merged
merged 8 commits into from
Aug 30, 2022
Merged

select support added for react-query components #83

merged 8 commits into from
Aug 30, 2022

Conversation

needim
Copy link
Collaborator

@needim needim commented Aug 29, 2022

This PR adds better type inference support for react-query options select, onSuccess, onSettled

closes: #82

@needim needim marked this pull request as draft August 29, 2022 01:57
@needim needim marked this pull request as ready for review August 29, 2022 02:13
@fabien0102 fabien0102 self-requested a review August 30, 2022 17:40
Copy link
Owner

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR! I could play with this typesafety for hours ^^

image

Just few tweaks are we should be good to go 👍

@needim needim requested a review from fabien0102 August 30, 2022 19:01
@needim
Copy link
Collaborator Author

needim commented Aug 30, 2022

This was my first PR and I forgot to create a feature branch for it. Had a conflict and fixed it. I think it is ok now.

Copy link
Owner

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks again for this amazing improvement! 💯

@fabien0102 fabien0102 merged commit 01574bc into fabien0102:main Aug 30, 2022
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select doesn't infer returned type
2 participants