This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Add ENABLE_DATAVOLUMES to deploy-kubevirt #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmazur hey - what#s the motivation for this change? |
|
Vanilla k8s is quite heavy for travis, especially when testing non–accelerated vms. OpenShift is even heavier. Enabling the datavolume gate post–deployment requires some pods to get restarted (afaik), which makes the whole thing even slower yet to deploy. This patch skips that restart, at least for the operator deployment, since everything is properly configured from the get go. And I'll take any speedup I can. Our PR that utilizes this: kubevirt/ansible-kubevirt-modules#214 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.