Feature/improve action testing #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could add more dedicated test when needed. Last step before publishing 1.2.0. |
sjcqs
approved these changes
Jul 30, 2020
AchrafAmil
reviewed
Jul 30, 2020
| # Check basic tools | ||
| java -version | ||
| rbenv -v | ||
| adb version |
There was a problem hiding this comment.
aren't we using gcloud instead of adb to run large tests ? 🤔
There was a problem hiding this comment.
@AchrafAmil We only testing here the Docker Container Action, which use the Docker Android image. So here we are just testing the wrapping of the Docker Android as a GitHub Action is ok, not the image itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #79