Added openjdk-17-jdk to the Dockerfile #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasygrand
approved these changes
Oct 11, 2023
|
@nicolasygrand any updates on this? |
|
Hello ! Thank you for your contribution. I will try to release a 1.8.0 version with this change ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone!
Thank you so much for providing us this awesome project.
As already mentioned here by other users, right now there's no way to use docker-android images with projects created with Android Studio Flamingo.
Basically, the problem is related to Gradle 8 which needs Java 17 to work, so I took the chance to edit the script a little bit (I also needed to migrate the project in the tests to make them succeed) and it's working as expected by running
./ci_cd.sh --android-api 33 --build-tools "33.0.1" --build --testI changed most of the files and I also updated the README, but feel free to request changes if you think more tests need to be added and/or other files need to be touched.
Many thanks!