Feature/multi env #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 28, 2020 18:18
Like with Fastlane, the idea is to move the ci business value behind an easy to use API, and not expose it directly from Github Action config files.
sjcqs
suggested changes
Mar 2, 2020
Dockerfile
Outdated
| @@ -58,4 +59,4 @@ RUN yes | sdkmanager --sdk_root=$ANDROID_HOME --licenses | |||
| RUN sdkmanager --sdk_root=$ANDROID_HOME --install \ | |||
| "platform-tools" \ | |||
| "build-tools;29.0.2" \ | |||
There was a problem hiding this comment.
- Latest stable version is 29.0.3
- Build-tools add support to build certain API level. If we use android-R / android-30 API level. The project won't be able to build.
However, if your strategy is to add support for android-30, android-31 and so on whenever there are release and update the install build-tools version, then I'm ok with that.
There was a problem hiding this comment.
Thanks for review!
Nice catch for the version, I will update that.
About the API level, I think it will works, the plateform will be downloaded when compiling the project which needs it.
At the end the idea here is to be able to post dedicated image with api level built in, to avoid this plateform download.
Is this what you had in mind?
sjcqs
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup multi images based on android-api.
Also extract CI detail of implementation from github action yml, into dedicated script (ci.sh).
Fix #3 .