Executor decision caching and single-host optimisations - #222
Merged
Conversation
Shillaker
marked this pull request as ready for review
February 9, 2022 15:03
Shillaker
requested review from
csegarragonz
and removed request for
csegarragonz
February 9, 2022 15:46
Shillaker
marked this pull request as draft
February 10, 2022 09:53
Shillaker
changed the title
Shillaker
marked this pull request as ready for review
February 10, 2022 16:53
Shillaker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two changes are tightly coupled as they both stem from a refactor of
Executor::executeThreads. This function is part of theExecutorAPI (e.g. called in Faasm to execute batches of threads). It was previously doing a lot of untested logic around caching scheduling decisions and updating snapshots, so updating it was difficult.This change includes a refactor of that function, and adding single-host optimisations, avoiding dirty tracking and snapshot merging for an app executing on a single host.
Changes:
CACHEDtopology hint to move decision caching into theScheduler.BatchExecuteRequests with asinglehostflag if executed only on the main host.