Retry GET from Redis for messages in the Execution Graph - #181
Merged
Conversation
csegarragonz
force-pushed
the
redis-get-retry
branch
from
November 25, 2021 17:42
b56176e to
6a0754a
Compare
csegarragonz
marked this pull request as ready for review
November 25, 2021 17:42
Shillaker
requested changes
Nov 26, 2021
| REQUIRE(node.msg.id() == req->mutable_messages()->at(i).id()); | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
This test isn't checking that it will fail when the max retries are hit, which seems like the easier case to check for.
Collaborator
Author
There was a problem hiding this comment.
I add another test that checks that you can't get an execution graph for a message that hasn't been published.
…for it in the tests
csegarragonz
force-pushed
the
redis-get-retry
branch
from
November 26, 2021 15:19
348b483 to
11194b2
Compare
Shillaker
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I fix a race condition that happened when running
Scheduler::getFunctionExecGraph()immediately afterScheduler::getFunctionResult()in a distributed setting.In particular, we sometimes generated the execution graph before all remote executors had published their resulting message. As a consequence,
redis.getwould return an empty byte array, and we'd cast it to an emptyfaabric::Message.I add a naive retry mechanism (bear in mind generating execution graphs is off the hot path), and a test that reproduces the failure with very little retries (in fact 10 tries might be an overkill).