Cmake Cleanup Faabric Part 2 - #165
Merged
Merged
Conversation
eigenraven
force-pushed
the
cmake-cleanup-2
branch
from
October 26, 2021 16:11
f5ab2d3 to
b76749f
Compare
eigenraven
force-pushed
the
cmake-cleanup-2
branch
from
October 27, 2021 08:34
b76749f to
d5904ef
Compare
eigenraven
marked this pull request as ready for review
October 27, 2021 08:51
Shillaker
approved these changes
Oct 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #164 : needs it to be merged first, and docker containers rebuilt.
This changes the dependency management from mostly CMake ExternalProject-based to mostly Conan-based, with a few odd dependencies still done using FetchContent until I can get access to the Conan repos and improve the "recipes" there.
I also removed headers from source lists in cmake targets, as they are ignored there anyway unless marked as PUBLIC_SOURCEs for installation - and are already covered by the existing install command in the top-level cmakelists.
Replaces #163