Allow merge regions to cross pages #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Oct 19, 2021
| SPDLOG_ERROR("Cannot convert snapshot data type to string: {}", dt); | ||
| throw std::runtime_error("Cannot convert data type to string"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure if there's a nicer way to do this. Could perhaps be done with a macro, but not sure it would be any clearer or take up fewer lines.
csegarragonz
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously merge regions could only be up to one page long. This is inconvenient and non-obvious to users of the API.
Changes: