Skip to content

Commit

Permalink
[receiver/kubeletstatsreceiver] update scope name for consistency (op…
Browse files Browse the repository at this point in the history
…en-telemetry#34537)

Update the scope name for telemetry produced by the
kubeletstatsreceiverreceiver from otelcol/kubeletstatsreceiver to
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiverreceiver

Part of
open-telemetry/opentelemetry-collector#9494

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
  • Loading branch information
codeboten authored and f7o committed Sep 12, 2024
1 parent 08f15c2 commit e6447b7
Show file tree
Hide file tree
Showing 22 changed files with 211 additions and 185 deletions.
27 changes: 27 additions & 0 deletions .chloggen/codeboten_update-scope-kubeletstatsreceiver.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: kubeletstatsreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "Update the scope name for telemetry produced by the kubeletstatsreceiver from `otelcol/kubeletstatsreceiver` to `github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver`"

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [34537]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func requireMetricsOk(t *testing.T, mds []pmetric.Metrics) {
requireResourceOk(t, rm.Resource())
for j := 0; j < rm.ScopeMetrics().Len(); j++ {
ilm := rm.ScopeMetrics().At(j)
require.Equal(t, "otelcol/kubeletstatsreceiver", ilm.Scope().Name())
require.Equal(t, "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver", ilm.Scope().Name())
for k := 0; k < ilm.Metrics().Len(); k++ {
requireMetricOk(t, ilm.Metrics().At(k))
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion receiver/kubeletstatsreceiver/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
type: kubeletstats
scope_name: otelcol/kubeletstatsreceiver

status:
class: receiver
Expand Down
2 changes: 1 addition & 1 deletion receiver/kubeletstatsreceiver/testdata/e2e/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ resourceMetrics:
stringValue: kind-control-plane
scopeMetrics:
- scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
metrics:
- name: k8s.node.cpu.time
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -45,7 +45,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -69,7 +69,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -93,7 +93,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -117,7 +117,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -141,7 +141,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -165,7 +165,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -189,7 +189,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -213,7 +213,7 @@ resourceMetrics:
name: k8s.pod.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -240,7 +240,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -267,7 +267,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -294,7 +294,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -321,7 +321,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -348,7 +348,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -375,7 +375,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -402,7 +402,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -429,7 +429,7 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
- resource:
attributes:
Expand All @@ -456,5 +456,5 @@ resourceMetrics:
name: k8s.container.cpu.node.utilization
unit: "1"
scope:
name: otelcol/kubeletstatsreceiver
name: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/kubeletstatsreceiver
version: latest
Loading

0 comments on commit e6447b7

Please sign in to comment.