Skip to content

Conversation

mwestphal
Copy link
Member

@mwestphal mwestphal commented Sep 21, 2025

Describe your changes

Need https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12475 and #2479

Issue ticket number and link if any

Related to #1100

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

Copy link

You are modifying versions.json, please update the timestamp as well, this will generate new docker images and caches needed for CI.

@mwestphal mwestphal marked this pull request as ready for review September 25, 2025 06:34
@mwestphal
Copy link
Member Author

\ci full

@mwestphal mwestphal force-pushed the mdl_stream_support branch 2 times, most recently from d88e6bc to 8fbaa94 Compare September 25, 2025 06:38
@mwestphal mwestphal requested a review from Meakk September 25, 2025 06:39
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.30%. Comparing base (123fa0e) to head (c335a29).

Files with missing lines Patch % Lines
plugins/native/module/vtkF3DQuakeMDLImporter.cxx 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2476      +/-   ##
==========================================
- Coverage   96.33%   96.30%   -0.04%     
==========================================
  Files         136      136              
  Lines       12859    12870      +11     
==========================================
+ Hits        12388    12394       +6     
- Misses        471      476       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants