#8 flyway 설정 추가 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeeJaeYun7
commented
Jul 25, 2023
LeeJaeYun7
commented
- flyway 설정을 추가했습니다
f-lab-moony
approved these changes
Jul 27, 2023
Collaborator
f-lab-moony
left a comment
f-lab-moony
left a comment
There was a problem hiding this comment.
고생많으셨어요 ~
코멘트 몇개 남겨 뒀는데, 다음 작업때 확인 부탁드려요 요건 머지 하도록 하겠습니다 ~
| @@ -0,0 +1,15 @@ | |||
| -- V1__init.sql | |||
| drop table if exists member; | |||
Collaborator
There was a problem hiding this comment.
drop은 굳이 안해줘도 될거같아요 ~
어차피 이 수행된 sql을 다시 수행 하려면 flyway reset 을 실행해야되는데, 그때는 초기화 된 뒤에 다시 처음부터 수행이 되거든요
flyway migrate 는 그 전까지 수행된건 제외 하고 그 뒤로 수행돼요 ~
| @@ -0,0 +1,15 @@ | |||
| -- V1__init.sql | |||
Collaborator
There was a problem hiding this comment.
flyway는 보통 날짜 시간을 파일명에 포함시켜요 ~
V2023.07.23.22.32.54__init_schema.sql요런 느낌으로요!
| CREATE TABLE member ( | ||
| MEMBER_ID BIGINT AUTO_INCREMENT PRIMARY KEY, | ||
| email VARCHAR(255) NOT NULL, | ||
| password VARCHAR(255), |
Collaborator
There was a problem hiding this comment.
password는 null이어도 되는걸까요 ? 아래 다른 컬럼들도요!
| role VARCHAR(50) NOT NULL | ||
| ); | ||
|
|
||
| CREATE INDEX i_member ON member (email); No newline at end of file |
Collaborator
There was a problem hiding this comment.
인덱스 이름을 좀 더 자세하게 적는 건 어떨까요 ?
특별한 컨벤션이 있는건 아니지만, IDX_MEMBER_EMAIL 처럼 테이블과 포함 컬럼이 드러나면 좋을 것 같아요!
f-lab-moony
added a commit
that referenced
this pull request
Aug 4, 2023
#9 Member 패키지 리팩터링 및 테스트 작성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.