#16 Heart 패키지 리팩토링 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeeJaeYun7
commented
Aug 29, 2023
LeeJaeYun7
commented
- Heart 패키지에 대한 리팩토링을 진행하였습니다
f-lab-moony
requested changes
Sep 2, 2023
Collaborator
f-lab-moony
left a comment
f-lab-moony
left a comment
There was a problem hiding this comment.
고생 많으셨습니다 ~
코멘트를 남겨 뒀는데, 저번 시간에 말씀드린 락 부분도 포함해서 한번 다시 다듬으시면 좋을 것 같아서 리뷰 재요청 드려요 ~
| Objects.requireNonNull(answer, "answer가 null입니다."); | ||
| Objects.requireNonNull(member, "member가 null입니다."); | ||
|
|
||
| this.id = id; |
Collaborator
There was a problem hiding this comment.
시퀀스 값인데 받을 필요가 있을까요 ~?
| if (heartRepository.findByAnswerIdAndMemberId(heartDTO.getAnswerId(), memberId).isPresent()) { | ||
| Long answerId = heartRequest.getAnswerId(); | ||
|
|
||
| Answer answer = answerRepository.findById(answerId).orElseThrow(() -> new CommonException(NOT_FOUND_ANSWER)); |
Collaborator
There was a problem hiding this comment.
요런 부분은 Repository를 직접 참조하지 않고, Service를 참조하면 재사용이 가능하지 않을까요 ?
| Long answerId = heartRequest.getAnswerId(); | ||
|
|
||
| decreaseHeartFacade(heartDTO.getAnswerId()); | ||
| Heart heart = checkHeartExists(answerId, memberId); |
Collaborator
There was a problem hiding this comment.
check~~ 메서드에서 boolean을 리턴하는게 낫지 않을까요 ?
f-lab-moony
approved these changes
Sep 8, 2023
Collaborator
f-lab-moony
left a comment
f-lab-moony
left a comment
There was a problem hiding this comment.
고생 많으셨습니다 ~
머지 하도록 할게요 ~
|
|
||
| @Builder | ||
| public Heart(Long id, Answer answer, Member member) { | ||
| public Heart(Answer answer, Member member) { |
|
|
||
| public interface AnswerLockRepository extends JpaRepository<Answer, Long> { | ||
|
|
||
| @Query(value = "select get_lock(:key, 3000)", nativeQuery = true) |
Collaborator
There was a problem hiding this comment.
timeout도 파라미터로 받는게 어떨까요 ~?
| answerLockRepository.getLock(answerId.toString()); | ||
| increaseAnswerHeartCnt(answerId); | ||
| } finally { | ||
| answerLockRepository.releaseLock(answerId.toString()); |
Collaborator
There was a problem hiding this comment.
위에 increaseAnswerHaertCnt 에서 SQL Exception이 발생하면, 이 구문은 실행 될까요 ?
| .modify(!ref.getCreatedDate().equals(ref.getModifiedDate())) | ||
| .myRef(ref.getMember().getId().equals(memberId)) | ||
| .heartCnt(refHeartRepository.countRefHeartByReferenceId(ref.getId())) | ||
| // .heartCnt(heartRepository.countRefHeartByReferenceId(ref.getId())) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.