Skip to content

#10 Question 패키지 리팩토링 및 테스트 작성 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f-lab-moony merged 8 commits into from
Aug 24, 2023
Merged

#10 Question 패키지 리팩토링 및 테스트 작성 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a002506
Question 패키지 Controller, Service 클래스 및 Test 리팩토링
LeeJaeYun7 Aug 15, 2023
bdbfa44
remove unused imports
LeeJaeYun7 Aug 15, 2023
9891eca
QuestionController 클래스 create 메소드 URL 수정
LeeJaeYun7 Aug 15, 2023
dcb95c2
PR 피드백 반영
LeeJaeYun7 Aug 21, 2023
7af8bc7
PR 피드백 반영2
LeeJaeYun7 Aug 21, 2023
d25b475
Question 패키지 리팩토링 & Question 인수 테스트 리팩토링
LeeJaeYun7 Aug 24, 2023
8ccb696
AnswerRepository findMyAnswer 반환 타입 수정
LeeJaeYun7 Aug 24, 2023
ab7978d
QuestionRepositoryTest 버그 수정, JpaAuditingConfiguration 클래스 삭제
LeeJaeYun7 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .gradle/6.7.1/fileHashes/resourceHashesCache.bin
View file
Open in desktop
Binary file not shown.
Binary file modified .gradle/6.7.1/javaCompile/classAnalysis.bin
View file
Open in desktop
Binary file not shown.
Binary file modified .gradle/6.7.1/javaCompile/jarAnalysis.bin
View file
Open in desktop
Binary file not shown.
187 changes: 0 additions & 187 deletions ...s/com.example.interviewPrep.quiz.Question.controller.QuestionCreateWebControllerTest.html
View file
Open in desktop

This file was deleted.

46 changes: 29 additions & 17 deletions build/reports/tests/test/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h1>Test Summary</h1>
</td>
<td>
<div class="infoBox" id="failures">
<div class="counter">0</div>
<div class="counter">1</div>
Copy link
Collaborator

@f-lab-moony f-lab-moony Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore에 build 하위 항목을 추가해주시는게 좋을 것 같아요 ~

Copy link
Collaborator

@f-lab-moony f-lab-moony Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위에 .gradle 하위 항목도 추가해주시는게 좋을 것 같습니다 ~

<p>failures</p>
</div>
</td>
Expand All @@ -38,7 +38,7 @@ <h1>Test Summary</h1>
</td>
<td>
<div class="infoBox" id="duration">
<div class="counter">0.838s</div>
<div class="counter">0.430s</div>
<p>duration</p>
</div>
</td>
Expand All @@ -47,8 +47,8 @@ <h1>Test Summary</h1>
</div>
</td>
<td>
<div class="infoBox success" id="successRate">
<div class="percent">100%</div>
<div class="infoBox failures" id="successRate">
<div class="percent">0%</div>
<p>successful</p>
</div>
</td>
Expand All @@ -58,13 +58,25 @@ <h1>Test Summary</h1>
<div id="tabs">
<ul class="tabLinks">
<li>
<a href="#tab0">Packages</a>
<a href="#tab0">Failed tests</a>
</li>
<li>
<a href="#tab1">Packages</a>
</li>
<li>
<a href="#tab1">Classes</a>
<a href="#tab2">Classes</a>
</li>
</ul>
<div id="tab0" class="tab">
<h2>Failed tests</h2>
<ul class="linkList">
<li>
<a href="classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html">QuestionUpdateWebControllerTest</a>.
<a href="classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html#updateWithNotExistedQuestion()">유효하지 않은 Question 업데이트 요청</a>
</li>
</ul>
</div>
<div id="tab1" class="tab">
<h2>Packages</h2>
<table>
<thead>
Expand All @@ -79,19 +91,19 @@ <h2>Packages</h2>
</thead>
<tbody>
<tr>
<td class="success">
<td class="failures">
<a href="packages/com.example.interviewPrep.quiz.Question.controller.html">com.example.interviewPrep.quiz.Question.controller</a>
</td>
<td>1</td>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.838s</td>
<td class="success">100%</td>
<td>0.430s</td>
<td class="failures">0%</td>
</tr>
</tbody>
</table>
</div>
<div id="tab1" class="tab">
<div id="tab2" class="tab">
<h2>Classes</h2>
<table>
<thead>
Expand All @@ -106,14 +118,14 @@ <h2>Classes</h2>
</thead>
<tbody>
<tr>
<td class="success">
<a href="classes/com.example.interviewPrep.quiz.Question.controller.QuestionCreateWebControllerTest.html">com.example.interviewPrep.quiz.Question.controller.QuestionCreateWebControllerTest</a>
<td class="failures">
<a href="classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html">com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest</a>
</td>
<td>1</td>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.838s</td>
<td class="success">100%</td>
<td>0.430s</td>
<td class="failures">0%</td>
</tr>
</tbody>
</table>
Expand All @@ -126,7 +138,7 @@ <h2>Classes</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="http://www.gradle.org">Gradle 6.7.1</a> at 2022. 11. 2. 오전 12:41:52</p>
<a href="http://www.gradle.org">Gradle 6.7.1</a> at 2023. 8. 24. 오후 3:26:02</p>
</div>
</div>
</body>
Expand Down
34 changes: 23 additions & 11 deletions build/reports/tests/test/packages/com.example.interviewPrep.quiz.Question.controller.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ <h1>Package com.example.interviewPrep.quiz.Question.controller</h1>
</td>
<td>
<div class="infoBox" id="failures">
<div class="counter">0</div>
<div class="counter">1</div>
<p>failures</p>
</div>
</td>
Expand All @@ -40,7 +40,7 @@ <h1>Package com.example.interviewPrep.quiz.Question.controller</h1>
</td>
<td>
<div class="infoBox" id="duration">
<div class="counter">0.838s</div>
<div class="counter">0.430s</div>
<p>duration</p>
</div>
</td>
Expand All @@ -49,8 +49,8 @@ <h1>Package com.example.interviewPrep.quiz.Question.controller</h1>
</div>
</td>
<td>
<div class="infoBox success" id="successRate">
<div class="percent">100%</div>
<div class="infoBox failures" id="successRate">
<div class="percent">0%</div>
<p>successful</p>
</div>
</td>
Expand All @@ -60,10 +60,22 @@ <h1>Package com.example.interviewPrep.quiz.Question.controller</h1>
<div id="tabs">
<ul class="tabLinks">
<li>
<a href="#tab0">Classes</a>
<a href="#tab0">Failed tests</a>
</li>
<li>
<a href="#tab1">Classes</a>
</li>
</ul>
<div id="tab0" class="tab">
<h2>Failed tests</h2>
<ul class="linkList">
<li>
<a href="../classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html">QuestionUpdateWebControllerTest</a>.
<a href="../classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html#updateWithNotExistedQuestion()">유효하지 않은 Question 업데이트 요청</a>
</li>
</ul>
</div>
<div id="tab1" class="tab">
<h2>Classes</h2>
<table>
<thread>
Expand All @@ -77,14 +89,14 @@ <h2>Classes</h2>
</tr>
</thread>
<tr>
<td class="success">
<a href="../classes/com.example.interviewPrep.quiz.Question.controller.QuestionCreateWebControllerTest.html">QuestionCreateWebControllerTest</a>
<td class="failures">
<a href="../classes/com.example.interviewPrep.quiz.Question.controller.QuestionUpdateWebControllerTest.html">QuestionUpdateWebControllerTest</a>
</td>
<td>1</td>
<td>1</td>
<td>0</td>
<td>0</td>
<td>0.838s</td>
<td class="success">100%</td>
<td>0.430s</td>
<td class="failures">0%</td>
</tr>
</table>
</div>
Expand All @@ -96,7 +108,7 @@ <h2>Classes</h2>
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by
<a href="http://www.gradle.org">Gradle 6.7.1</a> at 2022. 11. 2. 오전 12:41:52</p>
<a href="http://www.gradle.org">Gradle 6.7.1</a> at 2023. 8. 24. 오후 3:26:02</p>
</div>
</div>
</body>
Expand Down
Loading