테스트 코드 작성 #17
Merged
테스트 코드 작성 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DispatchQueue를 사용하지 않는 방법에서 막힘
f-lab-jercy
reviewed
Jan 29, 2024
Comment on lines
84
to
85
| let error = NetworkError.timeOut | ||
| repository.mockError = error |
There was a problem hiding this comment.
많은곳에서 이와 같은 코드가 사용되는데 setUpWithError와 같은 함수로 하나 만들어도 좋을것 같습니다!
There was a problem hiding this comment.
적용했습니다 ~!
| switch result { | ||
| case .success(let data): | ||
| XCTAssertFalse(data.program.isEmpty, "받아온 데이터가 비어있음") | ||
| XCTAssertEqual(data.program.first?.name, expectedName) |
There was a problem hiding this comment.
반환된 data.program의 모든 요소를 검증하거나, 반환된 데이터가 정확히 예상한 데이터와 일치하는지 전체적으로 확인이 필요해보입니다.
There was a problem hiding this comment.
적용한 커밋입니다 ! d1f81cc
There was a problem hiding this comment.
으아.. 내일 한번더 이부분에 대해서 얘기해보시죠!! 머지 합시다.!
Base automatically changed from
refactor/handle_error
to
feature/retry_request
February 12, 2024 10:35
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.