Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds lombok.Generated to proguard ignore warning configuration #394

Merged
merged 1 commit into from
Sep 20, 2023
Merged

adds lombok.Generated to proguard ignore warning configuration #394

merged 1 commit into from
Sep 20, 2023

Conversation

uklimaschewski
Copy link
Collaborator

No description provided.

@uklimaschewski uklimaschewski linked an issue Jul 30, 2023 that may be closed by this pull request
Bundle Proguard Rules #391
Closed
@uklimaschewski uklimaschewski changed the base branch from main to 3.1.x July 30, 2023 13:19
@uklimaschewski uklimaschewski changed the base branch from 3.1.x to main July 30, 2023 13:20
@uklimaschewski uklimaschewski mentioned this pull request Jul 30, 2023
Closed
vanniktech
vanniktech reviewed Jul 30, 2023
View reviewed changes
Copy link

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the file needs a proper file ending, hence: evalex.pro

@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

vanniktech
vanniktech approved these changes Jul 30, 2023
View reviewed changes
Copy link

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you very much 👌

@uklimaschewski uklimaschewski merged commit a560f46 into main Sep 20, 2023
3 checks passed
@uklimaschewski uklimaschewski deleted the 391-bundle-proguard-rules branch September 20, 2023 12:12
@vanniktech
Copy link

Hmm has anything changed regarding the process of how the JAR is published? This is broken with 3.2.0 & 3.3.0 versions. The file can no longer be picked up.

@vanniktech
Copy link

Never mind, this is an issue on Androids side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundle Proguard Rules
2 participants
@uklimaschewski @vanniktech