refactor: use tool names and descriptions as source of truth #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
added a commit
that referenced
this pull request
Mar 25, 2025
Some of our tools have TOOL_NAME_FOR_PROMPT and DESCRIPTION but they don't do anything right now. Refactor init_project.py to collect and use these as source of truth, and introduce these for all other tools. ```git-revs b9c2d48 (Base revision) fe38426 Adding imports and new function to __all__ e62b085 Adding collect_tool_descriptions function 35a1c5f Adding the collect_tool_descriptions call ff64edc Fixing duplication and preparing for system prompt construction b4792b2 Adding tool documentation generation logic 5836e37 Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to read_file.py 9443e12 Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to write_file.py d31da24 Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to edit_file.py 29a4fef Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to ls.py b7f1bfe Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to think.py 0d17e96 Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to glob.py 7587856 Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to user_prompt.py 28844fa Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to rm.py 8755cfd Adding TOOL_NAME_FOR_PROMPT and DESCRIPTION constants to run_command.py 948dac2 Auto-commit format changes HEAD Auto-commit lint changes ``` codemcp-id: 210-refactor-use-tool-names-and-descriptions-as-source ghstack-source-id: 506ff1560b9e47522f514170de7ae1572daef042 Pull-Request-resolved: #204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Some of our tools have TOOL_NAME_FOR_PROMPT and DESCRIPTION but they don't do anything right now. Refactor init_project.py to collect and use these as source of truth, and introduce these for all other tools.
codemcp-id: 210-refactor-use-tool-names-and-descriptions-as-source